Introduce ub variant for Result#1226
Open
mdittmer wants to merge 5 commits into
Open
Conversation
This change introduces a `Result` variant intended to model undefined behaviour (UB). The intent is to allow unsafe definitions and theorems to introduce proof obligations that formalize the conditions under which unsafe operations introduce undefined behaviour. Using a `Result` variant provides a natural abstraction asserting that undefined behaviour at a particular step determines all subsequent behaviour as undefined. Towards AeneasVerif#1225
Member
|
Thanks for this! What I had in mind was not to modify |
Contributor
Author
|
Yeah. I would appreciate more discussion about this question. I tend to agree with @joshlf 's assessment. The point that I would emphasize is that, AFAICT, developers can quite reasonably assume that |
Contributor
|
Repairs deliberately map `.ub => ⟨False⟩` in `mvcgen` bindings for `Result.instWP`. This matches the intuition that UB should be forbidden rather than another case for reasoning about weakest preconditions. Towards AeneasVerif#1225
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a
Resultvariant intended to model undefined behaviour (UB). The intent is to allow unsafe definitions and theorems to introduce proof obligations that formalize the conditions under which unsafe operations introduce undefined behaviour. Using aResultvariant provides a natural abstraction asserting that undefined behaviour at a particular step determines all subsequent behaviour as undefined.Towards #1225
AI assisted this PR as my "Lean tutor", helping me know where to look and what abstractions to reach for but not authoring any code.